phparkitect / arkitect

Put your architectural rules under test!
MIT License
703 stars 36 forks source link

Fix fatal error on startup with Symfony 7.x due to changes in command naming #420

Closed ben-challis closed 8 months ago

ben-challis commented 8 months ago

Fixes #419

Aligns with Check command which does:

    public function __construct()
    {
        parent::__construct('check');
    }
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cc7b3a0) 94.33% compared to head (290f831) 94.35%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #420 +/- ## ============================================ + Coverage 94.33% 94.35% +0.01% - Complexity 571 573 +2 ============================================ Files 67 67 Lines 1501 1505 +4 ============================================ + Hits 1416 1420 +4 Misses 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vibby commented 8 months ago

Thank you for PR, I was just starting to propose it too :) Can you please run php-cs-fixer to fix CI @ben-challis ?

ben-challis commented 8 months ago

The code style issues look to be unrelated to the changes in this PR and pre-existing but yep sure, I'll do it in a separate PR

src/Analyzer/NameResolver.php (phpdoc_add_missing_param_annotation, fully_qualified_strict_types, no_superfluous_phpdoc_tags)
ben-challis commented 8 months ago

@vibby https://github.com/phparkitect/arkitect/pull/421

vibby commented 8 months ago

Can you merge this too please @fain182 ?