search

phpbb-seo / usu

Ultimate phpBB SEO Friendly URL extension
GNU General Public License v2.0
17 stars 12 forks source link

Breadcrumb validation fails due to rewritten URL #46

Open teebling opened 3 years ago

teebling commented 3 years ago

Describe the bug :

In functions_display.php, phpBB builds the navigation links used in the breadcrumbs submenu. These breadcrumbs validate properly in both Google's Structured Data testing tool and Google's Rich Results Test tool when this extension is disabled.

However, when USU is enabled something goes wrong because the breadcrumbs microdata generated by functions_display.php is still based on URLs having forum ID in them.

When virtual folders are used to rewrite forum URLs (for example for example mydomain.com/myforum/) the forum ID is stripped, meaning that the microdata that is generated is incorrect and the 'item' field is not preprocessed, therefore the markup fails validation.

Is there any way we could stop this URL from being preprocessed by USU so that the breadcrumbs will actually work again?

teebling commented 3 years ago

Fixed this by removing the append_sid function from the relevant parts of functions_display.php and replacing it with a manually constructed URL, because I guess that's what USU targets.