phpbb-seo / usu

Ultimate phpBB SEO Friendly URL extension
GNU General Public License v2.0
17 stars 12 forks source link

Extension urls stay like original phpBB in the latest version when i update #54

Closed zetrader closed 3 years ago

zetrader commented 3 years ago

Hi, if i update to the latest version (git updated 18th of July 2021), the urls of forums, topics and post are the original from PhpBB, like if the extension is not active, no matter how i update the htaccess, disable/enable the extension, change options...

If i disable, delete, and came back to the previous version of git (downloaded 13th of July 2021), extension urls display nice again, forums, topics, posts...

So there's a bug with the last update that corrects the XSS, i'm talking about this update : https://github.com/phpbb-seo/usu/pull/53

The version downloaded before that (13th of july) doesn't make that bug.

ser commented 3 years ago

i think you must verify your installation - all works well with current master

zetrader commented 3 years ago

I have to reinstall the whole forum? As i said, if i delete the files of the extension and come back to the anterior version (downloaded 13th of july 2021), upload the files and enable extension, it works fine but i guess it has the vulnerability to reflected XSS attack.

ser commented 3 years ago

i do not know your environment, it works for me without any re-installation

zetrader commented 3 years ago

Ok, i've tried again with latest version (disable, delete files, upload latest version, enable), same bug, i've chosen the exact same options in the extension, changed nothing. Coming back to previous version (disable, delete files, upload latest version, enable), choosing the exact same options in the extenssion, it works again. I don't know where the bug can be, changing or not changing the .htaccess doesn't change anything, latest version does the bug, previous version does not.

My settings/options are :

URL rewriting type : advanced activate sql rewriting : yes sid removing : yes highlights removing : yes forum url caching : yes forum id removing : no Zero Duplicate

activate the zero duplicate : no strict mode : no post redirections : guest

zetrader commented 3 years ago

I now have tried with another domain name and directory, with a fresh new forum phpBB 3.3.4 (latest version), new database, and latest version of USU, still the same bug, urls are phpBB urls. If i disable, delete, upload and enable the previous version of USU with the same parameters : it works, urls are the good ones for forums, topics, posts.

EDIT : if i update directly the file /core/traits/url.php with the latest version of this file, i get the bug again, if i update with the previous version of this file, the bug is gone again. It's really the fix https://github.com/phpbb-seo/usu/pull/53 in that file that makes the bug.

ser commented 3 years ago

OK I did not not understand your initial bug report - you are correct, sorry :-) In current master urls are phpBB urls. It's clearly a bug.

meis2m commented 3 years ago

@marc1706 Hello dear marc , have you any opinion?

esginmurat commented 3 years ago

Hello all. i have same problem :( @ser @meis2m @zetrader @marc1706