Go back to previous code and use type_cast_helper to clean up data

phpbb-seo / usu

Ultimate phpBB SEO Friendly URL extension

GNU General Public License v2.0

17 stars 12 forks source link

Go back to previous code and use type_cast_helper to clean up data #56

Closed marc1706 closed 3 years ago

marc1706 commented 3 years ago

Should fix issues with #53 but also fix issues described in #54

Checklist:

[ ] Correct branch: master for new features & bug fixes
[ ] Tests pass
[ ] Code follows coding guidelines: phpBB coding guidelines

Describe the pull request :
A clear and concise description of what the pull request is for.

esginmurat commented 3 years ago

Dear @marc1706 thank you so much. It seems to work fine on phpbb 3.3.4 + php 7.4 + Ultimate phpBB SEO Friendly URL | 2.0.2 Dynamic Meta Tags phpBB SEO | 2.0.2-beta No Duplicate phpBB SEO | 2.0.0-b1 phpBB3 SEO Sitemap | 1.1.1

Regards

zetrader commented 3 years ago

I've updated the url.php with your new version, everything seems to be fine, forums urls, topics urls, post urls, if you want to check, my test forum here : http://aribaut.com/wiwi31/ USU with your last fix this morning, with php 8.0.8 and phpbb 3.3.4 msqli 5.7.33 New topic and posts made to check right now if there's any bug, but can not find one, works fine : http://aribaut.com/wiwi31/i-just-wanna-say-hi-folks-t24.html

Thanks Marc for the new fix :+1: