phpbb-seo / usu

Ultimate phpBB SEO Friendly URL extension
GNU General Public License v2.0
17 stars 12 forks source link

Way to allow custom URL parameters to not be rewritten? #58

Closed teebling closed 2 years ago

teebling commented 2 years ago

Is your feature request related to a problem? Please describe :
If I have configured my site to use virtual folders for forums and I visit one, let's say /trade/, the redirection works fine. Great. how about adding some parameters for sorting etc.? So if I go to /trade/?st=1, it correctly takes me to the filtered page, that's good. However, when I try and use custom parameters, let's say /trade/?sold=1, it always deleted this parameter and redirects me to /trade/ no matter what I do. I've looked hard at the htaccess, but there is nothing in there that makes this redirect happen, which suggests that it's in the extensions actual controller to ignore parameters unless they are 'st', 'sk', or 'd' (the standard phpBB ones).

Describe the solution you'd like :
I would like a FIND/REPLACE way of disabling this restriction, so that when I visit my URL with its custom parameter: /trade/?sold=1, I won't be redirected back to /trade/ every time. I want it to actually go through to/trade/?sold=1. The extension is always rewriting the parameter though. Can I get rid of this?

Describe alternatives you've considered :
I've looked through the core files and can see that this is where the issue lies - it seems to be hard coded into the ext to only allow the default parameters to go through and not custom ones.

Any ideas guys?

teebling commented 2 years ago

In /event/listener.php you need to redeclare custom params and label them as 'keep' in this document as well. Solved.