search

phpbb-seo / usu

Ultimate phpBB SEO Friendly URL extension
GNU General Public License v2.0
17 stars 12 forks source link

Solves functions_url_matcher.php warnings. #9

Closed Aspie96 closed 5 years ago

Aspie96 commented 5 years ago

Solves #3. I didn't notice any side effects after deleting the code.

image

The problem manifested when a user visited a page which was not a forum, whether existent or not, and whose URL did not contain a dot.

meis2m commented 5 years ago

Hello thanks did you test it ?

Aspie96 commented 5 years ago

I cannot guarantee it will work in every case because I don't know the code as well as you do (and the code itself comes with no warranty). Still, what I can tell you is that it's the version I am using right now on my board and it seems to work fine. I didn't notice any issue from removing those lines of code.

Il giorno mer 13 mar 2019 alle ore 10:46 Meisam Nobari < notifications@github.com> ha scritto:

Hello thanks did you test it ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/phpbb-seo/usu/pull/9#issuecomment-472350846, or mute the thread https://github.com/notifications/unsubscribe-auth/ANOy9dIL0gSAgj7mVEJR4QXeHObRZK4gks5vWMjrgaJpZM4brhtz .

Aspie96 commented 5 years ago

Thank you!