search

phpbb / epv

Extension Pre-Validator
GNU General Public License v2.0
9 stars 17 forks source link

Use semver to require the version of the Symfony components #43

Closed Nicofuma closed 8 years ago

Nicofuma commented 9 years ago

2.3,<2.7 is too restrictive and it disallow 2.8 even if it is compatible due to the BC promise. This prevent EPV to be installed along phpBB 3.2

paul999 commented 9 years ago

composer.phar update should be run to update the lock file.

However, this will partly break 3.1 support, as symfony has a higher php requirement (5.3.9) as 3.1 (5.3.3). I guess that wouldn't matter really, as most developers should be on higher releases.

Nicofuma commented 9 years ago

Actually it doesn't break it because it doesn't force the version to be 5.3.9. Composer will automatically select the best version according to your requirements and this includes the php entry in the require section but also your current php version

tierra commented 8 years ago

This doesn't help you if you're making use of the composer.lock file, and run a composer update while using PHP 5.3.10+, since even when you define "php": ">=5.3.3" in your require section, it's just checking a minimum, and it sees that you have 5.3.10+, so it'll update packages based on the version you're running, even if that means that it breaks compatibility for users using 5.3.3 on servers where they install your phpBB extension (which should be pre-packaged and ready to go).

On the other hand, I've also started using the following in my composer.json to lock in my minimum supported version, which is much more helpful, and allows you to run composer update from any PHP version like 5.6, and still require packages that are compatible with PHP 5.3.3, so maybe the point is moot:

    "config": {
        "platform": {
            "php": "5.3.3"
        }
    },