Check compatibility to 3.2.x packages and viglink-translation

[Crizz0]

• [ ] make sure, that the validator handles 3.2.x packages well with all needed and optional files
  • [ ] README
  • [ ] CHANGELOG
  • [ ] VERSION
  • [ ] Authors
• [ ] test additional viglink translation files
  • [ ] ext\phpbb\viglink\language\en\info_acp_viglink.php
  • [ ] ext\phpbb\viglink\language\en\viglink_module_acp

[Crizz0]

At the moment a german 3.2-language-pack for 3.2 fails the following errors.

 Fatal in ext/phpbb/viglink/language/de/info_acp_viglink.php:
Missing required file

 Fatal in ext/phpbb/viglink/language/de/viglink_module_acp.php:
Missing required file

 Fatal in language/index.htm:
Missing required file

 Fatal in styles/prosilver/theme/de/stylesheet.css:
Stylesheet file has additional CSS rules: .imageset.icon_user_online

 Error in language/de/AUTHORS.md:
Found additional file

 Error in language/de/README.md:
Found additional file

 Error in language/de/acp/board.php:DEFAULT_DATE_FORMAT_EXPLAIN:
String is using additional html: <a href="http://www.php.net/date">

 Error in language/de/acp/board.php:ACP_JABBER_SETTINGS_EXPLAIN:
String is using additional html: <a href="http://de.wikipedia.org/wiki/Jabber">

 Error in language/de/help/faq.php:HELP_FAQ_LOGIN_REGISTER_CONFIRM_ANSWER:
String is using additional html: <a href="#f07">

 Error in language/de/ucp.php:TERMS_OF_USE_CONTENT:
Should have 2 string arguments, but has 1

 Error in language/de/ucp.php:TERMS_OF_USE_CONTENT:
String is using additional html: <h3>

 Error in language/de/ucp.php:TERMS_OF_USE_CONTENT:
String is using additional html: <ol style="list-style-type: lower-alpha">

 Error in language/de/ucp.php:TERMS_OF_USE_CONTENT:
String is using additional html: <li>

 Error in language/de/ucp.php:PRIVACY_POLICY:
Should have 2 string arguments, but has 1

 Error in language/de/ucp.php:PRIVACY_POLICY:
String is using additional html: <h3>

 Error in language/de/ucp.php:PRIVACY_POLICY:
String is using additional html: <ol style="list-style-type: decimal;">

 Error in language/de/ucp.php:PRIVACY_POLICY:
String is using additional html: <li>

I'll check, what of them is relevant or what is wrong, the later has to be changed in the validator.

[nickvergessen]

Well the README and other additional files should be called REAME without file extension as per the guidelines: https://github.com/phpbb/phpbb-translation-validator/blob/master/src/Phpbb/TranslationValidator/Validator/FileListValidator.php#L170-L179

.md was only allowed as a transition phase

[nickvergessen]

test additional viglink translation files

Should be done automatically, see

Fatal in ext/phpbb/viglink/language/de/info_acp_viglink.php:
Missing required file

 Fatal in ext/phpbb/viglink/language/de/viglink_module_acp.php:
Missing required file

[Crizz0]

Okay, thanks for the info :)

[Crizz0]

Yes, was curious if something else should be useful.

[Crizz0]

Close via #34