search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 9 forks source link

.md file handling in phpBB 3.2.0 #34

Closed Crizz0 closed 7 years ago

Crizz0 commented 7 years ago

33

Crizz0 commented 7 years ago

Can someone take a look at the tests and help me with the failed ones?

nickvergessen commented 7 years ago

Well the problem is not related to your change directly. It's just you test 3.2 now and there is subsilver2 special handling for that.

The problem is that the tests contain styles/subsilver2 https://github.com/phpbb/phpbb-translation-validator/tree/master/src/Phpbb/TranslationValidator/Tests/FileListValidator/fixtures/source

My suggestion would be to duplicate the fixtures into version based subfolders (fixtures/3.0, fixtures/3.1, fixtures/3.2), kill the subsilver2 files in 3.2,

move

        $this->validator->setOrigin('origin', dirname(__FILE__) . '/fixtures/origin', 'language/origin/')
            ->setSource('source', dirname(__FILE__) . '/fixtures/source', 'language/source/');

from setUp to testValidateFileList and use the version in the path as well.