search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 8 forks source link

Allows additional images .gif or .png for rtl translations #40

Closed Crizz0 closed 6 years ago

Crizz0 commented 7 years ago

Fix #32

DavidIQ commented 7 years ago

Tests are failing.

Crizz0 commented 7 years ago

I see, he is missing a file in fixtures/PHPVERSION/...

So i can fix it, by placing the file in three folders like 3.0, 3.1, 3.2 etc. or fix the path, where he is looking for it. Maybe that is the better solution.

Elsensee commented 7 years ago

I'd recommend to place the file in the folder for the different versions because there might be differences in handling language files between versions.

When tests are failing, it mostly is because of new code - not because of the tests. So fixing tests should not be the general way to go.

Crizz0 commented 7 years ago

When my include of the common, which is the new code, can be changed to find in normal mode and in the test the file, that would be perfect. Wouldn't change the test here.

Crizz0 commented 6 years ago

@DavidIQ Still necessary changes needed?

DavidIQ commented 6 years ago

No this is fine as is. Thanks.