search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 9 forks source link

Img with /> and > lead to fatal error (HTML5 support) #45

Closed Crizz0 closed 4 years ago

Crizz0 commented 6 years ago

https://github.com/phpbb/phpbb-translation-validator/pull/43#issuecomment-354446120

battye commented 5 years ago

What do you want the expected behavior for this to be? To allow img html tags to pass without errors?

So I take a random key:

'CAPTCHA_RECAPTCHA'             => 'reCaptcha',

Turn it into:

'CAPTCHA_RECAPTCHA'             => 'reCaptcha <img src="test.png" />',
'CAPTCHA_RECAPTCHA'             => 'reCaptcha <img src="test.png">',

Which results in:

Fatal in language/de/captcha_recaptcha.php:CAPTCHA_RECAPTCHA:
String is using additional html: <img src="test.png" />

Fatal in language/de/captcha_recaptcha.php:CAPTCHA_RECAPTCHA:
String is using additional html: <img src="test.png">
Crizz0 commented 5 years ago

The problem iirc was, that e.g. French translators changed everything to HTML5, where phpBB en was still HTML5 and xhtml1.0. so the validator complained, that there was additional html used. I think I did a bloody dirty workaround. But need to look it up.

Crizz0 commented 4 years ago

@MilesCellar Do you still have this problem?

Could you the describe it in your words?

qiaeru commented 4 years ago

No, I no longer have the issue. If it resurfaces, I will reopen a issue for it.

Thank you! 👍