search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 9 forks source link

Improve support for RTL languages #48

Closed Crizz0 closed 3 years ago

Crizz0 commented 6 years ago

Some RTL (right to left) languages, like Arabic etc. need not only a translated "online"-image, but they need extra CSS to display it correctly. Or increase in some point the font size or similar fixes.

But I am not sure, if this should be fixed in phpBB-core for RTL support or if we should be more tolerant in allowing additional rules for RTL languages.

battye commented 5 years ago

How do we know if a language is RTL when running it through T.V.? And what would being more tolerant involve? Would we suppress errors, etc?

british_english_3_2_5/british_english_3_2_5/ext/phpbb/viglink/language/en
british_english_3_2_5/british_english_3_2_5/language/en
british_english_3_2_5/british_english_3_2_5/styles/prosilver/theme/en
Crizz0 commented 5 years ago

We have this: https://github.com/phpbb/phpbb/blob/master/phpBB/language/en/common.php#L45

Yes, maybe we transform a FATAL error into a Warning or Error, there. But only in certain limits.

battye commented 5 years ago

Okay, so we can check if DIRECTION === 'rtr'.

If at some point you can make a list of the cases where you would like fatal turned into warning or error, I don't mind applying the code changes :)