search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 9 forks source link

Bugfix for using TV as a dependency #60

Closed battye closed 5 years ago

battye commented 5 years ago

Using phpbb-translation-validator as a dependency stopped working.

This is the bug @rxu and @senky discovered - more information at https://www.phpbb.com/community/viewtopic.php?p=15239786#p15239786

To fix this, I updated composer.json and changed the include path in translation.php.

@rxu confirmed this fix at https://travis-ci.org/rxu/Olympusrupack/builds/522760744 (just waiting on confirmation that it will work if the travis yml file uses vendor/bin/translation.php before approving this PR).

battye commented 5 years ago

@rxu I couldn't go to sleep without knowing, so I cloned your repository and tried running the test from vendor/bin :stuck_out_tongue: 

vendor/bin/translation.php validate ru --phpbb-version=3.2 --display-notices

That worked for me, so I suspect that will work on your Travis CI test as well. Be aware though, that it might only work if you don't have php at the beginning of the line in your .travis.yml file. So if what you have now doesn't work, this might work instead:

script:
  - vendor/bin/translation.php validate $PHPBB_LANGUAGE --phpbb-version=$PHPBB_VERSION --display-notices
rxu commented 5 years ago

Tests pass with php vendor/bin/translation.php command. https://travis-ci.org/rxu/Olympusrupack/builds/522763511

battye commented 5 years ago

Fantastic, thanks for confirming that @rxu :sunglasses: