search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 9 forks source link

-V not showing version number #62

Closed scootergrisen closed 5 years ago

scootergrisen commented 5 years ago

-V only shows: Console Tool

There is no version number.

Using phpbb-translation-validator-1.4.1.zip

DavidIQ commented 5 years ago

Same here we are on version 1.5.1. Did you make a typo?

scootergrisen commented 5 years ago

No its the one on https://www.phpbb.com/community/viewtopic.php?f=79&t=2205631#p13425776

DavidIQ commented 5 years ago

Then you're on the wrong version. We'll remove those attachments.

scootergrisen commented 5 years ago

Same in 1.5.1.

paul999 commented 5 years ago

The parameter is something we inherit from symfony it looks like, but we never set the version, and thats why it shows empty.

DavidIQ commented 5 years ago

I'll just leave this open for now then in case @Crizz0 wants to implement. Otherwise he can close as there is no indication we were going to implement this command anyways.

battye commented 5 years ago

Showing the version is easy to add, I've put a PR at https://github.com/phpbb/phpbb-translation-validator/pull/63