Closed Crizz0 closed 4 years ago
Sounds good 😊
Am 24. Oktober 2019 15:10:09 MESZ schrieb battye notifications@github.com:
battye approved this pull request.>
Looks good to me.>
If you're about to release a new version, I just have one wish - and that is that we can close one of the other remaining issues while we have the opportunity. Like https://github.com/phpbb/phpbb-translation-validator/issues/45 for example, I'm happy to do whatever code changes are necessary if you can explain exactly what the problem is. 🙂 >
-- > You are receiving this because you authored the thread.> Reply to this email directly or view it on GitHub:> https://github.com/phpbb/phpbb-translation-validator/pull/65#pullrequestreview-306559779
No 3.3 tests yet, just allow it and bump the version.