search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 8 forks source link

Update the symfony-2.8 branch with latest changes #66

Closed battye closed 4 years ago

battye commented 4 years ago

@Crizz0 - Something I've been playing with. I merged your latest version into symfony-2.8, then wiped the composer.lock changes and did a fresh composer install.

Would you be able to try testing this too? Thanks

Crizz0 commented 4 years ago

I've tested this with phpBB 3.3.0 packages between "en" and "es".

And 3.2.9 packages with "en" and "tr".

In both cases, with forced errors and stuff, the result between this branch/PR and the 1.5.2-release are the same.

So looks good to me :)

DavidIQ commented 4 years ago

This only works on PHP 7.1 and up right?

Crizz0 commented 4 years ago

This only works on PHP 7.1 and up right?

I did run my tests of the TV with this branch locally with PHP 5.6 and PHP 7.2.26. Worked fine.

To make PHP 5.6 possible, battye created this branch with the older symfony version.

DavidIQ commented 4 years ago

Why are the Travis tests for 5.6 and 7.0 failing then?

Crizz0 commented 4 years ago

Because a few dependencies require PHP 7.0/7.1 and it looks like, the package built stops immediately in the travis test. Maybe something we could improve further.