search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 9 forks source link

Fix handling of html-tags in ToU and PP #68

Closed Crizz0 closed 4 years ago

Crizz0 commented 4 years ago

Fixes #67

battye commented 4 years ago

That change makes sense to me, it looks good.

battye commented 4 years ago

For future reference, I asked about the v4 thing in the Symfony chatroom, here were some of the answers:

In my Symfony 4.4 project some packages also got updated to 5.x because they aren’t limited explicitly

if you want to limit symfony/debug to <4 you also need to add: "symfony/debug": "~3.0"

or add extra: {symfony: {require: 3.4.* }} into your composer.json file

Crizz0 commented 4 years ago

Yes, that is my plan. I will revert the composer.lock change here.

But we need to look at this later on.

Am 9. November 2020 14:39:41 MEZ schrieb battye notifications@github.com:

@battye commented on this pull request.

     },

{ "name": "symfony/debug",

  • "version": "v3.4.36",
  • "version": "v4.4.15",

@Crizz0 maybe the composer.lock change can be removed from the PR so that only the LangKeyValidator.php code change flows through?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/phpbb/phpbb-translation-validator/pull/68#discussion_r519820656

Crizz0 commented 4 years ago

Mhm, like this is at the moment, the patch will break validation for phpBB 3.2.11 language packages.

So i added a if-sentence for this version to avoid this.