More lenient validation rules for RTL languages

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html

GNU General Public License v2.0

8 stars 8 forks source link

More lenient validation rules for RTL languages #69

Closed battye closed 3 years ago

battye commented 3 years ago

Using Arabic and Persian as examples, some of the rules are more lenient now for right-to-left languages (#48):

If there's additional HTML and it looks like it's to do with hard coding something to do with direction (check for ltr or rtl in the HTML) then downgrade to just a warning
If it's an RTL language then be more lenient on stylesheets having additional CSS rules

Are you able to check this @Crizz0 and let me know if there's any other rules we should be more lenient for?

Crizz0 commented 3 years ago

Looks good! :)

I looked through the recent validations.

The only thing I could imagine of additional HTML to PRIVACY_POLICY and TERMS_OF_USE_CONTENT could be handled like a warning, if it is something like: <h3>, <h4>, <br>, <ul>, <ol>, <li>, <p>, which is used sometimes to give those wall of texts more structure, if needed. But not really necessary, imho.