Make TLV compatible with master-branch => composer.json

[Crizz0]

The current master will use a composer.json for the language files: https://github.com/phpbb/phpbb/blob/master/phpBB/language/en/composer.json

We should add some functions to check this file:

• [x] validate the composer json
• [x] Check for the right version in "version": "4.0.0-a1-dev",
• [ ] Need to check for the information from former iso.txt https://github.com/phpbb/phpbb/blob/3.3.x/phpBB/language/en/iso.txt

  "extra": {
      "language-iso": "en",
      "english-name": "British English",
      "local-name": "British English",
      "phpbb-version": "4.0.0-a1-dev"
  }

• [ ] Maybe improve core code, to add reCAPTCHA and plural rules to the composer.json, too.

[battye]

Hi @Crizz0 - I'm taking a look at this now. Should this just be the lowest level of error message (notice) at this stage because not many language packs have composer.json files yet? Or do you want to change the rules so it becomes mandatory now and translators become familiar with adding the json file in there?

[Crizz0]

This should introduce a new optional version 4.0 to validate against.

With default 3.3 composer.json should be not asked for.

But for 4.0 this should be mandatory then, yes. But the iso.txt and what else is replaced by the composer.json should not be there, and flagged as additional file.

[battye]

@Crizz0 Could you please explain this line a bit more?

Maybe improve core code, to add reCAPTCHA and plural rules to the composer.json, too.

Is that something different to what was merged in https://github.com/phpbb/phpbb-translation-validator/pull/59?

[Crizz0]

Hi,

phpBB-master removed the current config-file for phpBB 3.3.x and lower: the phpBB/language/en/iso.txt is gone.

Instead there is a composer.json used now: https://github.com/phpbb/phpbb/blob/master/phpBB/language/en/composer.json

The validator needs to be updated for this composer.json.

Although the composer.json is the new config-file for translations, there are other files which contain "setup information" like: https://github.com/phpbb/phpbb/blob/master/phpBB/language/en/common.php#L45-L53 or https://github.com/phpbb/phpbb/blob/master/phpBB/language/en/captcha_recaptcha.php#L42

So maybe it is worth to update the phpBB-core in that relation, that those information are all within the new composer.json. Which will lead to a further update to the TVL.

Maybe @marc1706 has some thoughts on this, too. :)

[battye]

The validator needs to be updated for this composer.json.

Is the change in https://github.com/battye/phpbb-translation-validator/commit/fbd2740cb1d2af7ac40818842f1ec86aca0bcf04 what you had in mind for the composer.json? (e.g. check that the 'extra' information is present, that the four attributes are there, that the version number matches)

phpBB-master removed the current config-file for phpBB 3.3.x and lower: the phpBB/language/en/iso.txt is gone.

I'll test it again, but I think if the iso.txt file is removed from the master package then it would automatically not check for it in the translation package (because it checks that the file structure is the same, so if it's not in the source then it will pretend it doesn't exist). There are a few mentions of sourceIso in the code but I'm pretty sure that's just shorthand for the language name like de or fr or en.