search

phpbb / phpbb-translation-validator

A tool checking packages for compliance with the policies https://area51.phpbb.com/docs/dev/3.2.x/language/guidelines.html
GNU General Public License v2.0
8 stars 9 forks source link

[ticket/7] Don't force decored parameter #8

Closed carlo94it closed 10 years ago

carlo94it commented 10 years ago

See #7

nickvergessen commented 10 years ago

Thanks :)

nickvergessen commented 10 years ago

This actually removes colours from travis: https://travis-ci.org/phpbb-de/phpbb-translation/jobs/28610950 So we might either add a force option, or revert this

carlo94it commented 10 years ago

On my machine it work successfully.

I will try it again tomorrow.

nickvergessen commented 10 years ago

Yeah locally it works just fine, but travis does not like it.

carlo94it commented 10 years ago

I think that Travis delete ANSI codes, because this line of Phing (German phpBB Translation > validate:) is also colored, but Travis don't ouput it.

nickvergessen commented 10 years ago

But it worked before your patch: https://travis-ci.org/phpbb-de/phpbb-translation/jobs/28544055

carlo94it commented 10 years ago

You can force ANSI by adding --ansi to .travis.yml file.

I think that the console component don't detect the Travis ANSI support automatically.

carlo94it commented 10 years ago

Infact see here. Travis worker doesn't use tty console.

nickvergessen commented 10 years ago

--ansi seems to do the trick