search

phpbbmodders / phpbb-3.1-ext-adduser

A port of the phpBB 3.0.x version of the Add User Mod
GNU General Public License v2.0
11 stars 10 forks source link

Point out locale used in board #19

Closed bissim closed 8 years ago

bissim commented 8 years ago

The localisation variable put there with no proper separators in the sentence may lead to misunderstandings, since it's a two characters word. A real misunderstanding occurs when %s = it, making the sentence unreadable and ununderstandable.

Apart from that, it would be cleaner to put the variable apart from the sentence.

bonelifer commented 8 years ago

@RMcGirr83 what do you think about this change?

rmcgirr83 commented 8 years ago

Should be fine. Not sure if it is even needed anymore. Sort of remember a fall back being put in place via a pull by CHIta in core.

bissim commented 8 years ago

@rmcgirr83 in 1.0.3 the message is still showed and since I forgot about this PR I was like wut what's wrong with this weird message:

The language you have chosen it does not have the files needed for the extension. Please translate them and upload to the it directory of the extension to use the extension.

I mistook again it for the English pronoun instead of the locale code.