search

phpbenchmarks / benchmark-kit

phpbenchmarks.com kit to add your benchmark.
http://www.phpbenchmarks.com
30 stars 4 forks source link

[4.0] Error on command "nginx:vhost:statistics:create" #137

Closed Tantrisse closed 4 years ago

Tantrisse commented 4 years ago

Hello !

When using the command phpbenchmark nginx:vhost:statistics:create X.X an error is thrown because the script try to right the template for statistics in the /var/benchmark-kit/public directory of the container. This folder is owned by root:root with default file permission so the current user (phpbenchmarks) can't write the file.

Why when building the container, don't you give ownership of the public folder to "phpbenchmarks" (as you do for the entrypoint file) ?

Or you could set this public folder as chmod 777 like nginx and the var folder. As you commented in the dockerfile, there is no security concern in this app so lot's of solution here ^^

I can do a PR with your preferred solution if you want / need !

steevanb commented 4 years ago

You're right, thanks! It's fixed.