search

phpbenchmarks / benchmark-kit

phpbenchmarks.com kit to add your benchmark.
http://www.phpbenchmarks.com
30 stars 4 forks source link

Fix preload host registration + preload url generation #148

Closed Tantrisse closed 4 years ago

Tantrisse commented 4 years ago

Hello,

This PR fix the missing registration of the "preload-generator.benchmark-kit.loc" domain into the hosts files (host machine + container).

Secondly, it fix the preload generator URL by appending the benchmark relative URL. I used the same logic of the getStatisticsUrl function. This way, the correct URL is used and displayed in order to fetch the correct class list by calling the final benchmark URL.

Let me know if everything is OK !

steevanb commented 4 years ago

Good work!

For now i've only tested the kit without Docker, so maybe you will find some bugs like this one.