search

phpbenchmarks / benchmark-kit

phpbenchmarks.com kit to add your benchmark.
http://www.phpbenchmarks.com
30 stars 5 forks source link

GitHub Action benchmarking? #162

Open MGatner opened 3 years ago

MGatner commented 3 years ago

Hello phpbenchmarks! I'm hailing from CodeIgniter 4. Frequently we will have PRs come up (like this and this) that the code will all seem fine but there are larger questions of performance. That got me thinking how I would evaluate a PR to answer the question: "Will this change significantly impact the framework's performance?"

My solution: a GitHub Action that returns a relative benchmark result similar to Code Coverage that could be assessed for "pass" or "failure". I've poked around at benchmarking and found you all, ready to go with your benchmark kit.

My question: Has anyone tried wrapping this kit in a GitHub Action? Would you be willing to work with us on launching a CodeIgniter 4 kit?

steevanb commented 3 years ago

Hi!

I have same idea as your ;) For now i don't know if GitHub actions is the right solution: a simple task could take 1 sec as 10 sec... so benchmark results could be not comparable.

For now i'm working on full automation each time a new tag is created on a repository, to generate code and start benchmark.

When it will be finished, I will work on this idea :)