search

phpclassic / php-shopify

PHP SDK for Shopify API
Apache License 2.0
570 stars 210 forks source link

Logging #116

Open stevenbrookes opened 5 years ago

stevenbrookes commented 5 years ago

Hi Tareq

We've got the requirement to log requests and responses to/from Shopify. Are you interested in a pull request to add logging to a PSR-3 logger, like Monolog? If so then I'll put something together and send it to you.

Regards

Steve

tareqtms commented 5 years ago

@stevenbrookes You are welcome for pull request. But remember that it should be configurable and by default it will be off, we should be able to switch it on or off using the $config array.

stevenbrookes commented 5 years ago

Thanks. Agreed on the approach.

Steve

From: Tareq Mahmood notifications@github.com Sent: 12 September 2019 09:56 To: phpclassic/php-shopify php-shopify@noreply.github.com Cc: Steven Brookes steven.brookes@talisman-innovations.com; Mention mention@noreply.github.com Subject: Re: [phpclassic/php-shopify] Logging (#116)

@stevenbrookes https://github.com/stevenbrookes You are welcome for pull request. But remember that it should be configurable and by default it will be off, we should be able to switch it on or off using the $config array.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phpclassic/php-shopify/issues/116?email_source=notifications&email_token=AKJVX3MSUVJKU7REANMMEU3QJH72RA5CNFSM4IVV4ES2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6RFMEQ#issuecomment-530732562 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKJVX3PWJPBJQQYZ3DKKCSLQJH72RANCNFSM4IVV4ESQ .

This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

ivanivkovic commented 4 years ago

This will be pretty valuable if it's implemented