search

phpcq / repository

The base repository containing tool specifications
0 stars 1 forks source link

Feature phpspec support #8

Closed dmolineus closed 2 years ago

dmolineus commented 4 years ago

This pull request prepares the support for phpspec Before merging it, we need to solve issues in the plugin-api first:

Note: Using the phar version of phpspec seems not be very stable as they do not scope their phar file right now but also autoloads the project autoload.php. https://github.com/phpspec/phpspec/issues/1301

Note: This PR depends on feature/checkstyle, that's why I based it on the branch for the moment.

discordier commented 3 years ago

Needs to be rebased against the current interfaces (mainly the severity names have changed).

dmolineus commented 3 years ago

Because of https://github.com/phpspec/phpspec/issues/1288 it doesn't make much sense to use phpspec as phar tool or a separated tool from the main dependencies of a project. So I don't know how we can go on here.

discordier commented 3 years ago

Adding the question tag for the moment as we need to decide how to proceed.

dmolineus commented 3 years ago

For our gnupg repository I ship a local plugin which rund vendor/bin/phpspec. If we agree to ship such plugins within our repository I would finish the implementation. Using the phar approach won't unfortunately work here.