search

phpcr / phpcr-shell

PHPCR Shell
MIT License
69 stars 19 forks source link

Reconsider node:definition command #172

Open dantleech opened 8 years ago

dantleech commented 8 years ago

Since Jackalope now supports retrieving the NodeDefinition from the Node instance, the command node:definition has become available, and it doesn't work, so I have removed it.

I had thought that the NodeDefinition was the NodeTypeDefinition, and planned to show the CND. Infact, I think the information we gain from the Definition could be added to node:info, which currently reads:

PHPCRSH > node:info cmf
/cmf
+-------------------+--------------------------------------+
| UUID              | f46286b4-33af-43bc-8e6a-fcf263f004f9 |
| Index             | 1                                    |
| Primary node type | nt:unstructured                      |
| Mixin node types  | mix:referenceable                    |
| Checked out?      | N/A                                  |
| Locked?           | [ERROR] Not implemented by jackalope |
+-------------------+--------------------------------------+

@dbu wdyt?

dbu commented 8 years ago

the definition can be rather verbose. i think node:definition is better than node:info --show-definition or something like that.