search

phpcr / phpcr-shell

PHPCR Shell
MIT License
68 stars 19 forks source link

Refactored to add missing inheritance check #191

Closed middlebrain closed 6 years ago

middlebrain commented 6 years ago

Let PHPCR handle the node type checking including inheritance. See issue https://github.com/phpcr/phpcr-shell/issues/190

dbu commented 6 years ago

i restarted the builds that failed to install because of network issues. but the one that ran notices that there is a unit test that fails now because the method on the mock node is not expected to be called. could you adjust that test please?

dbu commented 6 years ago

thank you! the remaining failure is not related to this pull request but is a test issue in the node type definition. (the order change is not relevant there)

@middlebrain would you be motivated to add php 7 to the test matrix and see if you can fix that test error? this tool was developped and maintained by @dantleech but he currently does not have time to work on it...

middlebrain commented 6 years ago

@middlebrain would you be motivated to add php 7 to the test matrix and see if you can fix that test error?

I have made pull requests (https://github.com/phpcr/phpcr-shell/pull/192 and https://github.com/phpcr/phpcr-shell/pull/194) for that issues.