search

phpcr / phpcr-shell

PHPCR Shell
MIT License
68 stars 19 forks source link

Add php 7.x to the test matrix #194

Closed middlebrain closed 6 years ago

middlebrain commented 6 years ago

Fix behat runtime errors by using php 7.x Travis: build with 7.x

dbu commented 6 years ago

thanks a ton for picking this up! and it seems to look like there are no issues with php 7.

i let styleci fix the styling in the master branch. can you please rebase?

the test that fails is "Execute the note-type show command" and it looks like the ordering of that node type definition changed in jackrabbit. i am confident that the order is not relevant - can you please change the order in what we expect?

dbu commented 6 years ago

re the failing test: sorry, i saw you did a separate pull request. the other PR is merged, so when you rebase this on master, it should get green \o/

middlebrain commented 6 years ago

re the failing test: sorry, i saw you did a separate pull request.

My bad. Looking back, I should have better combined the two pull requests into one.

the other PR is merged, so when you rebase this on master, it should get green \o/

Rebase made.

dbu commented 6 years ago

great, thanks a lot!

do you want to become a contributor for this project? as we currently don't have an active maintainer, it would be great to have somebody taking care of it a bit.

middlebrain commented 6 years ago

As an active user of php-shell, I just wanted to fix the most annoying bugs.

There are more things that bother me. But I don't have time to dive deeper into it right now.

dbu commented 6 years ago

sure - happy to look at merge requests when you send them. just thought i'd ask if you want a more official role on the project.