Add symfony 5 support

[alexander-schranz]

This is still in process.

TODO

• [x] Use symfony phpunit bridge to support this wide range of symfony and php versions
• [x] Use webmozart/assert instead of phpunit assert for supporting different version of php and symfony
• [x] Update Symfony EventDispatcher
• [x] Update Symfony Console
• [x] Make tests green 🙏

[dantleech]

I think we can bump the minimum PHP requirement to 7.2 - this PR introduces support for Symfony 5 which has that requirement, and anybody who wants to use Symfony 4 will just get the previous version of this package.

That should solve some of the build issues (if not all of them)!

[dbu]

seems fair to me. you could still support php 7.0 or 7.1 with older symfony versions, but i don't think that is an important consideration - the shell seems to be quite stable, so no problem for people stuck on old php to use an old version.

[alexander-schranz]

@dantleech do you have maybe a hint what could cause the errors which are appearing in embedded and standalone tests? I'm very unfamiliar with behat 🙈

[dantleech]

hmm, Jackrabbit just returns 503 both with 2.18 and 2.8 - @dbu do you recall what error you had with the ODM?

[alexander-schranz]

@dantleech downgraded the travis dist and it should work now I hope 🙏

[dantleech]

downgraded the travis dist and it should work now I hope

Well found - fixed forever! :smile: strange that it doesn't work on newer dists

[alexander-schranz]

@dantleech sadly php 7.2 get stuck on the following test:

Feature: Edit a node type

    In order to modify a node type definition

    As a user that is logged into the shell

    I should be able to run a command which launches an external editor to edit the CND as a text file

if I read that it sounds to me the editor is really started and never closed and thats why it don't continue or what do you think?

EDIT: jackolope/jackolope need atleast 1.3.4 for PHP 7.2

[alexander-schranz]

@dantleech Finally I found the working prefer lowest dependencies.

[dantleech]

:tada: well done :)

[dantleech]

Thanks again, let me know when you want a tag

[alexander-schranz]

@dantleech Tag would be great or atleast an update of the branch alias in the composer.json :)

[dantleech]

Can you assert that master works with f.e. Sulu?

[alexander-schranz]

@dantleech not yet there still to many dependencies which are not yet compatible with symfony 5 🙈

[alexander-schranz]

@dantleech tested can be released :)

[alexander-schranz]

@dantleech could we create a release for this and the phpcr-migrations-bundle?

[dantleech]

Release 1.2.0 :tada: sorry for the delay

[dantleech]

Also 1.2.0 of migrations

[alexander-schranz]

@dantleech Thank you 🎉