search

phpcr / phpcr-shell

PHPCR Shell
MIT License
69 stars 19 forks source link

Adding `void` return type to command #221

Closed mamazu closed 11 months ago

mamazu commented 11 months ago

In Symfony 6 not having this type is deprecated and it can't hurt in 5.4 either. This is not a BC break as Return Type narrowing (the implementation of an interface can have a narrower return type than the interface implementing it) was introduced in 7.4 and the result of the configure method is used nowhere.

dantleech commented 11 months ago

not entirely sure if I still maintain this, but looks good!

dbu commented 11 months ago

thanks. do we need : int return type declaration for the execute method as well?

mamazu commented 11 months ago

Yes, I will do that as well.