[WIP] fix parsing dots in literals

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself

phpcr.github.io

Other

72 stars 30 forks source link

[WIP] fix parsing dots in literals #104

Closed dbu closed 3 years ago

dbu commented 10 years ago

it seems we have an issue parsing literals that immediately start with other delimiter tokens, like "..".

this looks good, however one of the tests in jackalope-doctrine-dbal fails.

lsmith77 commented 10 years ago

ping?

dbu commented 10 years ago

i am still confused about the thing i commented on. @dantleech do you have some insight?

dantleech commented 10 years ago

@dbu sorry, I tried to understand this class but failed, and decided it would be better to rewrite it but havn't committed myself to that yet :) In anycase it would be alot easier to develop if there were some tests here (we just need a lightweight way to access the Jackalope QOMFactory). I think even that the SQL2 stuff could be in a separate package.

dbu commented 3 years ago

fixed in #194