Refactored node type register command to be more flexible re. loading - Githubissues

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself

phpcr.github.io

Other

72 stars 30 forks source link

Refactored node type register command to be more flexible re. loading #108

Closed dantleech closed 10 years ago

dantleech commented 10 years ago

This PR:

Allow multiple files to be specified
Allow folders to be specified

Its a BC break in that it forces at least one target option to be secified, whereas before there was a required argument for a single CND file.

This PR also keeps in mind support for YAML files instead of CND (I am currently working on a YAML importer + dumper).

dantleech commented 10 years ago

Updated, keeping backwards compatibility, but explicitly marking as depreacated.

dantleech commented 10 years ago

ok, updated to use an argument array instead of options, thanks @dbu

dantleech commented 10 years ago

... and fixed the tests.

dbu commented 10 years ago

i think just passing the list as arguments rather than parameter is fine for the new syntax. but we should keep the cnd-file parameter for BC compatibility and only drop it on a new major release.

the tests seem not really fixed.

dantleech commented 10 years ago

ok makes sense, reverted the name of the argument.

The failing test does not seem to be related to this PR.

1) PHPCR\Tests\Util\NodeHelperTest::testBenchmarkOrderBeforeArray

PHP_Invoker_TimeoutException: Execution aborted after 1 second

dbu commented 10 years ago

can you please update the doc? then its good to merge imho.

dantleech commented 10 years ago

Updated doc.

dbu commented 10 years ago

looking good. could you add a bit to the doc, and then squash your commits?

dantleech commented 10 years ago

Updated + Squashed