search

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself
phpcr.github.io
Other
72 stars 30 forks source link

Refactored Converter to make it more extensible #118

Closed dantleech closed 10 years ago

dantleech commented 10 years ago

Made in association with: https://github.com/phpcr/phpcr-shell/pull/68

dbu commented 10 years ago

cool! the only worry is the sql2 field that is now commented out.

dantleech commented 10 years ago

Updated, Apparently the comment thing is "valid" according to PHP, fixed in anycase. Added a test to ensure that the class is at least instantiable.

dantleech commented 10 years ago

Failing on benchmark test:

1) PHPCR\Tests\Util\NodeHelperTest::testBenchmarkOrderBeforeArray

PHP_Invoker_TimeoutException: Execution aborted after 1 second
dbu commented 10 years ago

benchmark seems a close one, travis did not fail on the last update of your commit :-)

lsmith77 commented 10 years ago

this merge is causing a regression: https://travis-ci.org/jackalope/jackalope-jackrabbit/jobs/30823367