search

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself
phpcr.github.io
Other
72 stars 30 forks source link

PHP 7.0 & 7.1 support #165

Closed ElectricMaxxx closed 7 years ago

ElectricMaxxx commented 7 years ago

fix #164

ElectricMaxxx commented 7 years ago

Please review and merge and release, please :-)

dbu commented 7 years ago

looking at https://github.com/ElectricMaxxx/phpcr-utils/blob/1.2.8/src/PHPCR/Util/QOM/Sql2Scanner.php#L162-L165 i think the problem really is that 1.2.8 is not compatible with php 7.

i just removed the allowed failures in a separate pr before seeing this one. will cherry-pick the test cleanup you do here

dbu commented 7 years ago

merged manually in f212d3f27cce243de90d037c9d71135a27889d5f

ElectricMaxxx commented 7 years ago

while you where doing it i reverte my last commit too :-)

dbu commented 7 years ago

i won't tag a release for this, as it will make no difference for the problem. i don't see why we end up with 1.2.8 being installed. maybe we should up our requirement to ^1.2.9 (the problem is that 1.2.8 is installable with php 7 even though its broken, but we can't fix that issue directly)

ElectricMaxxx commented 7 years ago

No worries, won't need a release as the fix is still on 1.2.9 :-)