search

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself
phpcr.github.io
Other
72 stars 30 forks source link

add unit tests for Sql2ToQomQueryConverter #22

Open lsmith77 opened 12 years ago

dbu commented 11 years ago

@dantleech i noticed that in phpcr-utils, there is a bunch of open tickets about the PHPCR query builder. would be great if you could have a look through them and comment on those you think are now fixed.

dantleech commented 11 years ago

The issues in phpcr-utils seem to be related to the Sql2QomConverter and other SQL stuff, I don't think I have fixed any of them (knowingly), although I suspect #3 works now.

On Sat, Jan 12, 2013 at 12:27:02AM -0800, David Buchmann wrote:

@dantleech i noticed that in phpcr-utils, there is a bunch of open tickets about the PHPCR query builder. would be great if you could have a look through them and comment on those you think are now fixed.

— Reply to this email directly or view it on GitHub.

*

dbu commented 11 years ago

we have lots of functional tests in phpcr-api-tests that test the query converter. do we still need unit tests?

lsmith77 commented 11 years ago

i think it would be nice to have some basic tests if just for during development .. however in reality we will always test things with the functional tests. so its not critical imho.