search

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself
phpcr.github.io
Other
72 stars 30 forks source link

CND Parser first commit #30

Closed dantleech closed 11 years ago

dantleech commented 11 years ago

This is just an early commit to register that I'm working on it, nothing works yet, so don't pay it much attention.

dantleech commented 11 years ago

Heh, I see that @sixty-nine has actually written a parser already, serves me right for not checking the issues first https://github.com/phpcr/phpcr-utils/issues/18.

dbu commented 11 years ago

uh oh. i suggest we try to merge the two efforts. #18 seems to have stopped on an open question that we were not able to figure out back then. @sixty-nine are you ok if @dantleech would take your code over to phpcr-utils and combine with his to finalize things?

if you both want to work on the PR, i can also give you write access to phpcr-utils so you can collaborate.

sixty-nine commented 11 years ago

yes I agree, but basically the parser is written, all that remains to do on my side (and I don't really have time to figure out how) is to actually generate the node definitions.

sixty-nine commented 11 years ago

BTW @dantleech I remain at your disposal if you need information about what already exists.

dbu commented 11 years ago

@dantleech would you be ok to do a PR against the cnd-parser branch (you can select the target branch when creating a PR, master is just the default). you could add your tests and eventual cleanup. plus the open question mentioned in #18

dantleech commented 11 years ago

yeah sure. will have a look at somepoint today.

dbu commented 11 years ago

superseeded by #31