Delete hard references - Githubissues

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself

phpcr.github.io

Other

72 stars 30 forks source link

Delete hard references #33

Closed dbu closed 11 years ago

dbu commented 11 years ago

continuing the work of #24 - i plan to work on this january 13th

check if the session is transaction capable and if it is and its not inside a transaction, start one
first remove all properties of root node (in case they are hard references)
delete hard references recursively on each but the first non-system child node - can we use a query for that?
delete the non-system child nodes
if we started a transaction, close it

dbu commented 11 years ago

i start to have serious doubts if we really need this. reading http://www.day.com/maven/jsr170/javadocs/jcr-2.0/javax/jcr/Session.html#save() it seems the check should only be done at save time (presumable exactly to avoid the problem with removing multiple trees of nodes).

i wrote a test where i play the whole process and it works fine with jackrabbit. @simensen did you try with doctrine-dbal or jackrabbit storage? maybe when you did it, we still had a bug with jackrabbit... would be great if you could re-try with a current jackalope-jackrabbit and see if we still have something not working.

dbu commented 11 years ago

i added the test i wrote to debug this at https://github.com/phpcr/phpcr-api-tests/pull/75

dbu commented 11 years ago

@simensen ping

simensen commented 11 years ago

@dbu I apologize for not responding earlier. I was using Dotrine DBAL storage at the time. I recall that it was discussed that it could be a problem/limitation with Doctrine DBAL itself. Unfortunately I never got around to firing up Jackrabbit in my environment so I was never able to tell if it was isolated to Doctrine DBAL or not.

My code was boxed and is pretty stale. I last touched it back in August. I'm sure a lot of things have changed since then. Did you run your new tests with both Jackrabbit and DBAL? If so, and it works, I'd guess that it is probably good to go.

dbu commented 11 years ago

thanks @simensen. i checked with doctrine-dbal and indeed there i get an error. that is however a bug of jackalope-doctrine-dbal. i created https://github.com/jackalope/jackalope-doctrine-dbal/issues/84

i suggest we merge this branch later, once its sorted out, for the naming cleanup.

dbu commented 11 years ago

so in the end this is an issue on the jackalope-doctrine-dbal side, which is about to be fixed so i merged this.

simensen commented 11 years ago

@dbu thanks. :) i apologize i could not have been more help here at the end. :(

dbu commented 11 years ago

no worries, thanks for bringing the topic up and showing where the problem was, that helped a lot. the actual solution is the biggest jackalope refactoring of this year (because a lot of hidden crap was hiding behind this "small" thing)