Closed dantleech closed 11 years ago
thanks, merged this. if you want to fix visibility of the properties to protected, please just do against master directly (or do you not have commit rights?)
I changed the visibility because we might want to access these properties from a closure - and I normally do not declare properties in tests, so they default to being public. So there is maybe a small "real" reason and another personal coding style creep :)
fine for me, i don't mind for the tests.
Options were being passed with wrong keys.. hmm.