implement parsing of CAST(), automatically parse dates inside literals

phpcr / phpcr-utils

A set of helper classes and command line commands you want to use with phpcr, but that are not part of the API itself

phpcr.github.io

Other

72 stars 30 forks source link

implement parsing of CAST(), automatically parse dates inside literals #99

Closed lsmith77 closed 10 years ago

lsmith77 commented 10 years ago

fix https://github.com/phpcr/phpcr-utils/issues/98

lsmith77 commented 10 years ago

did a minor refactoring .. but its not so simple with the code duplication. i ran into issues with the call to $this->scanner->getPreviousDelimiter() with a date that contained a dot character (i.e. '.') .. not sure if this is a general issue with this code to try and fix delimiters that are "eaten" by the parser but the gist is that right now the code is not the same ..

dbu commented 10 years ago

ah, that seems strange. we should be able to parse anything that is in a quoted string i guess. should we open an issue about that?

dbu commented 10 years ago

but thanks for implementing CAST and date guessing! cool that we have this now!