search

phpdave11 / gofpdi

Go Free PDF Document Importer
MIT License
118 stars 59 forks source link

fix: setting sourceFile on the reader when importing streams #60

Closed johan-lejdung closed 8 months ago

johan-lejdung commented 1 year ago

fixes a bug where it wasn't possible to import from more than one stream at a time. As described in https://github.com/phpdave11/gofpdi/issues/59

johan-lejdung commented 1 year ago

@phpdave11 anything else I can do to help move this along?

dekiftw commented 8 months ago

@phpdave11 I have tested this fix and can confirm that it works! I kindly ask that this PR gets merged as soon as possible.

johan-lejdung commented 8 months ago

I should mention that we've been running this code in Production since my bugfix, we haven't had any issues with it as of yet.

Are any of the contributors active? @phpdave11 @mrtsbt @mcdee @awesomeunleashed

awesomeunleashed commented 8 months ago

Are any of the contributors active? @phpdave11 @mrtsbt @mcdee @awesomeunleashed

I don't have merge permissions, so I can't help you there unfortunately.

phpdave11 commented 8 months ago

Thank you! I will merge this PR now and create a new gofpdi and gofpdf release tonight.

romanpickl commented 6 months ago

@phpdave11 the release wasn't created yet, right?

johan-lejdung commented 6 months ago

Seems it's still missing :/

@phpdave11 the release wasn't created yet, right?