Closed Maikuolan closed 6 years ago
Diff also shows quite a few lines being changed which weren't actually changed (added/removed lines look the same). Not quite sure what's going on there, unless some line endings were accidentally modified during commit or something like that. Hopefully won't cause problems, but might be worth checking before accepting this PR. Let me know if there are problems (if so, I can re-fork and try again from scratch, to see whether that might solve it).
Thanks for the update :)... I guess we'll need to refactor these yaml files a bit also because they aren't synced with README later on... I'll add this one for now. Thank you.
It is most likely this issue: https://help.github.com/articles/dealing-with-line-endings/ (if this happens to you on other repos, check your Git configs)
Previous line endings were LF
and new ones are now CRLF
. The LF
is what we want in these files, but don't worry about these now because these need to be refactored anyway a lot to be utilized in the README.md...