phpfu / puphpet

Hosts the unpacked version of the zip produced by puphpet.com.
MIT License
5 stars 2 forks source link

Update release #10

Open deizel opened 9 years ago

deizel commented 9 years ago

If you use a fresh config.yaml from the PuPHPet website, the VM doesn't start on vagrant up.

$ touch .gitignore
$ composer update
$ cp ~/Downloads/1BUV10/puphpet/config.yaml puphpet/config.yaml
$ vagrant up
# snip
==> default: Error: Invalid parameter locations on node packer-virtualbox-iso-1422601639
==> default: Error: Invalid parameter locations on node packer-virtualbox-iso-1422601639
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.
>>> elapsed time 1m31s

Seems this repo has fallen out-of-sync with the main website and it's probably time to update it again.

I've created a new release on my fork so that I can use that for the time being:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/deizel/puphpet-release"
        }
    ]
}

Is there a plan to automate this, or do you think #8 is a better option?

beporter commented 9 years ago

There is in fact a plan to automate this using my team's test server, but it's currently held up by #3. If we make changes to the scraping process and push our changes to this repo, then any place where that scraping process is already automated (say via cron) will essentially break since its upstream remote will have changed. It will be trying to push new release/s without having first pulled those upstream changes we added. Think of this like an "automatic update" function that is currently missing.

8 is also an option, but that might even be better off as a completely separate composer package. (Basically a cousin of loadsys/puphpet-release-composer-installer that does most of bin/scrape-release.sh "on the fly" directly when you call composer require. That would be extremely un-composer-like, of course.)

The puphpet/puphet project changes so rapidly that this is bound to be an ongoing issue. That's why this project is designed to tag new minor versions for every scraping run-- the idea is that consuming project must manually verify that 1.57.0 still works for them when they've been stable on 1.23.0. (We're using minor semver versions to represent the fact that upstream puphpet changes are frequently and unpredictably backwards-incompatible.)

I apologize for forcing you to resort to using a fork, but until #3 is implemented and tested, I'm afraid that's probably going to be your best bet. :sweat:

beporter commented 9 years ago

As suggested in #9; when automatic updates are eventually online, we should update the README to not target a specific version (since composer will apparently "do the right thing" with the versions for us.)

README.md:

-$ composer require --dev loadsys/puphpet-release:~0.0.4
+$ composer require --dev loadsys/puphpet-release