search

phpfui / ConstantContact

MIT License
16 stars 7 forks source link

add session_start(); to be sure sessions are enabled #2

Closed jmalko closed 2 years ago

jmalko commented 2 years ago

Using Laravel 8 - sessions do not pass to this library out of the box. Sessions must be enabled before using them in the Client.php file.

phpfui commented 2 years ago

Jonathan, I am going to reject this PR as I don't think this is the best way to do this.

But, good find! I will see what I can come up with. The old library did not use sessions, as it did not need to store anything between requests. I just assume everyone is using sessions, but probably not a good assumption.

Will look for best practice on this.

Thanks for testing.