phphants / phph-site

Website for www.phphants.co.uk
MIT License
12 stars 7 forks source link

Error when logging in with GitHub when email is not available #171

Open asgrim opened 7 years ago

asgrim commented 7 years ago

When trying to log in with a GitHub account that does not have an email address, creating of the ThirdPartyAuthenticationData fails because the email is null.

Argument 3 passed to App\Service\Authentication\ThirdPartyAuthenticationData::new() must be of the type string, null given, called in /data/home/phphants/phph-site/src/App/Service/GitHub/GitHubAuthentication.php on line 73

asgrim commented 7 years ago

A couple of potential solutions I can think of: