search

phpinnacle / ridge

Pure asynchronous PHP implementation of the AMQP 0-9-1 protocol.
MIT License
50 stars 13 forks source link

Default timeout bug #17

Closed michalzielanski closed 2 years ago

michalzielanski commented 3 years ago

In the configuration, the default timeout is written as milliseconds: https://github.com/phpinnacle/ridge/blob/adcced8abecc26ec26c407fb18e3ef59bcb06594/src/Config.php#L25-L26 and in the client it is additionally multiplied by 1000: https://github.com/phpinnacle/ridge/blob/adcced8abecc26ec26c407fb18e3ef59bcb06594/src/Client.php#L103 Timeout in configuration should be in seconds or milliseconds?

mmasiukevich commented 2 years ago

It was fixed a long time ago