search

phpinternalsbook / PHP-Internals-Book

PHP Internals Book
http://www.phpinternalsbook.com/
Other
1.39k stars 177 forks source link

Update object handlers #123

Closed iluuu1994 closed 2 years ago

iluuu1994 commented 2 years ago

This file only exists for the PHP 5 part of the book, I wonder if it's time to merge those and just make master match the current master version of php-src itself.

nikic commented 2 years ago

Updating the PHP 5 part with PHP 7 docs doesn't make sense. The object section would likely need a from scratch rewrite for PHP 7, because things changed a lot in that area.

iluuu1994 commented 2 years ago

@nikic I only noticed that this was in the PHP 5 section after. Should I copy the whole chapter to the 7 section and remove anything that's no longer accurate? Does it make sense to keep the two versions around?

iluuu1994 commented 2 years ago

@nikic I copied the handler descriptions to the PHP 7/8 section and removed anything else that might be outdated. There were also some handlers missing which I added. Let me know if this looks good to you. Could you grant me edit access to this repository? I won't merge anything without creating an PR first except for minor non-technical things like typos.