search

phpipam / phpipam

phpipam development repository
https://phpipam.net
2.22k stars 730 forks source link

[Feature Request] Make Circuit map display link when either end of circuit terminates in Device #2094

Closed dagbdagb closed 3 years ago

dagbdagb commented 6 years ago

I love the new feature which allows for color- and patterncoding the links. But in the process of testing out this feature, I notice that the circuit-map does not draw the links if either end of the defined circuit terminates in a device. The link is drawn in the little map on the page where you define the circuit, but not on the circuit-map itself.

Is this by design? All my devices are associated with a location, so I would assume this information could be utilized to show the circuit in the right place.

dagbdagb commented 6 years ago

@nhowe91 Seeing how you fixed #2111 in no time flat... what do you think about this? Is it a bug or just a missing feature?

nhowe91 commented 6 years ago

Hey @dagbdagb, this is a missing feature for now. I remember when working on the logical circuits part I and added the logic to check the circuits assigned to device and to grab the location there. It shouldn't take too much to get this to the all circuit map. I had meant to do that before I submitted the pull request but I must have looked over it

I'm wanting to rework the all circuits map in general though, once it starts getting a lot of different circuits going from the same location A/location B, the map starts to get a bit laggy

dagbdagb commented 6 years ago

@nhowe91 Cool. I'll look out for future PRs from you. If you find a way to add the cid to the map as well, I will not protest heavily. :-)