phpmentoring / webapp

PHP Mentoring matching website
http://php-mentoring.org/
MIT License
46 stars 30 forks source link

Show mentor spoken languages to profile #95

Closed gabidavila closed 7 years ago

gabidavila commented 8 years ago

I think this is a good idea for those who want to have a mentor but not necessarily speaks english thus other people can get help even if they are using the translated version of the website (Google/Bing Translator).

dragonmantank commented 7 years ago

👍 to this idea.

We already show the time zones, this is another great idea to add.

gabidavila commented 7 years ago

OK, I am gonna tackle it :)

dragonmantank commented 7 years ago

Just as a heads up, the src/ directory has undergone a renovation, so a bunch of things (like stuff relating to the Profile forms) are under new namespaces. Profile form stuff is now under Mentoring\Account\Form.

gabidavila commented 7 years ago

@dragonmantank I was thinking about adding it as a text optional field. However after coding it, I thought about storing as we store the tags.

If this way is acceptable the feature is complete (the optional text field) if it should have the same behaviour as tags I need to implement it. Please let me know your opinion.

Link for my branch.

dragonmantank commented 7 years ago

Been thinking this over, and doing it like the tags is probably the better way. It will make searching and auto-completion easier in the future when we enhance the mentor search page.

gabidavila commented 7 years ago

Ok, sgtm :)