phpmetrics / PhpMetrics

Beautiful and understandable static analysis tool for PHP
https://phpmetrics.github.io/website/
MIT License
2.48k stars 259 forks source link

page has invalid html #483

Closed gemal closed 1 year ago

gemal commented 2 years ago

PHPMetrics v2.8.1

wrong tag is closed so span is not closed and then td is closed 2 times:

image

niconoe- commented 1 year ago

Hi @gemal

This is fixed in the incoming v3 of PhpMetrics. If you want this to be fixed on the version 2.8, please provide a PR.

Thanks a lot for using PhpMetrics :slightly_smiling_face:

gemal commented 1 year ago

Hi @gemal

This is fixed in the incoming v3 of PhpMetrics. If you want this to be fixed on the version 2.8, please provide a PR.

Cool. When do you expect v3 to become available? And what features will be included?

niconoe- commented 1 year ago

I'm trying to spend some time on v3, but that's a long road. Major changes will be:

There's no due date for v3 unfortunately, but I will probably provide a beta version soon as I have troubles to test a lot of different kind of projects, and having users feedback could help a lot.

gemal commented 1 year ago

can you make a 2.8.2 release since this is already fixes on master?

niconoe- commented 1 year ago

This is not fixed on master. master is currently on the same status than version 2.8.1 + very minor stuff, but not this fix.

gemal commented 1 year ago

I'm pretty sure this one is already fixed on master https://github.com/phpmetrics/PhpMetrics/blob/master/templates/html_report/index.php#L150

niconoe- commented 1 year ago

@gemal The v3.0.0rc1 has just been released. Please give it a try and share your feedback regarding this issue, as it should now be solved.

Thanks a lot!

niconoe- commented 1 year ago

Fixed since v3.0.0rc1. Closing